pfSense

link_interface_to_tunnelif(): Make it consistent

Change link_interface_to_tunnelif() to always return an array and
simplify logic used when it's used removing unneeded checks

Do not unset variables that will be set on next line

This appears to be causing unintended fallout. Reverting for now.

Revert "Delete static routes on gateway down. Fixes #11296"

This reverts commit 3fca57f8fae3733845c90338943c418bb77e68b7.

Remove urlencode() for NoIP.com DDNS credentials. Fixes #12021.

Change pkg install variable references. Fixes #11290

• For whatever reason, PHP was failing to copy certain values into
  $pkg_data which was a reference to the pkg configuration, so drop that
  and use the $config variable directly.
• While here, fix initialization of pkg tab contents...

Correct RADVD log message on HA event. Fixes #11966

Use 'tos' rather than 'dscp' keyword for pf DSCP matching

The 'dscp' keyword is pfSense-specific, but doesn't do anything more
than the FreeBSD 'tos' keyword.
Using 'tos' will let us remove a diff from our local FreeBSD branch.

schedule: Use the new multi-label support

We've removed the pfsense specific 'schedule' keyword, and now use the new
multi-label support. That is, schedules are now just another label (prefixed
with 's:'). We also use the classic pfctl kill option (-k) rather than...

Tell pf to keep counter values

Pf can attempt to preserve (rule) counter values across rule updates.
We've reverted our home-grown implementation and switched to the upstream
implementation. We must tell pf to actually do this, so 'set keepcounters'.

Init pkg plugin array before use. Fixes #11290